libxl regression: don't require vncpasswd when password is empty string

Don't require an empty password when the guest config file
has the entry
     vncpasswd=''

Instead, do not require a password at all in this case.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index b660dbf21d1690b6419295af32bd5db3f728df55..bc0bae7a96676fe80d4520671e45badac5493878 100644 (file)
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -74,7 +74,7 @@ static char ** libxl_build_device_model_args_old(libxl__gc *gc,
         } else {
             vncarg = "127.0.0.1:0";
         }
-        if (info->vncpasswd)
+        if (info->vncpasswd && (info->vncpasswd[0] != '\0'))
             vncarg = libxl__sprintf(gc, "%s,password", vncarg);
         flexarray_append(dm_args, "-vnc");
         flexarray_append(dm_args, vncarg);